Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43d96390 authored by Julia Lawall's avatar Julia Lawall Committed by Michal Marek
Browse files

Coccinelle: limit memdup_user transformation to GFP_KERNEL case 



Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
only allow this flag in the original code.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMichal Marek <mmarek@suse.com>
parent 29b4817d

scripts/coccinelle/api/memdup_user.cocci

+4 −4
Original line number Diff line number Diff line
@@ -15,11 +15,11 @@ virtual org 
virtual report



@depends on patch@

expression from,to,size,flag;

expression from,to,size;

identifier l1,l2;

@@



-  to = \(kmalloc\|kzalloc\)(size,flag);

-  to = \(kmalloc\|kzalloc\)(size,GFP_KERNEL);

+  to = memdup_user(from,size);

   if (

-      to==NULL
@@ -37,12 +37,12 @@ identifier l1,l2; 
-  }



@r depends on !patch@

expression from,to,size,flag;

expression from,to,size;

position p;

statement S1,S2;

@@



*  to = \(kmalloc@p\|kzalloc@p\)(size,flag);

*  to = \(kmalloc@p\|kzalloc@p\)(size,GFP_KERNEL);

   if (to==NULL || ...) S1

   if (copy_from_user(to, from, size) != 0)

   S2