Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4311051c authored by Yong Zhang's avatar Yong Zhang Committed by Ben Dooks
Browse files

i2c: irq: Remove IRQF_DISABLED 



Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: default avatarYong Zhang <yong.zhang0@gmail.com>
Acked-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarBarry Song <21cnbao@gmail.com>
Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
parent 1fdb24e9

drivers/i2c/busses/i2c-bfin-twi.c

+2 −2
Original line number Diff line number Diff line
@@ -631,7 +631,7 @@ static int i2c_bfin_twi_resume(struct platform_device *pdev) 
	struct bfin_twi_iface *iface = platform_get_drvdata(pdev);



	int rc = request_irq(iface->irq, bfin_twi_interrupt_entry,

		IRQF_DISABLED, pdev->name, iface);

		0, pdev->name, iface);

	if (rc) {

		dev_err(&pdev->dev, "Can't get IRQ %d !\n", iface->irq);

		return -ENODEV;
@@ -702,7 +702,7 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev) 
	}



	rc = request_irq(iface->irq, bfin_twi_interrupt_entry,

		IRQF_DISABLED, pdev->name, iface);

		0, pdev->name, iface);

	if (rc) {

		dev_err(&pdev->dev, "Can't get IRQ %d !\n", iface->irq);

		rc = -ENODEV;

drivers/i2c/busses/i2c-designware.c

+1 −1
Original line number Diff line number Diff line
@@ -755,7 +755,7 @@ static int __devinit dw_i2c_probe(struct platform_device *pdev) 
	i2c_dw_init(dev);



	writel(0, dev->base + DW_IC_INTR_MASK); /* disable IRQ */

	r = request_irq(dev->irq, i2c_dw_isr, IRQF_DISABLED, pdev->name, dev);

	r = request_irq(dev->irq, i2c_dw_isr, 0, pdev->name, dev);

	if (r) {

		dev_err(&pdev->dev, "failure requesting irq %i\n", dev->irq);

		goto err_iounmap;

drivers/i2c/busses/i2c-highlander.c

+1 −1
Original line number Diff line number Diff line
@@ -387,7 +387,7 @@ static int __devinit highlander_i2c_probe(struct platform_device *pdev) 
		dev->irq = 0;



	if (dev->irq) {

		ret = request_irq(dev->irq, highlander_i2c_irq, IRQF_DISABLED,

		ret = request_irq(dev->irq, highlander_i2c_irq, 0,

				  pdev->name, dev);

		if (unlikely(ret))

			goto err_unmap;

drivers/i2c/busses/i2c-nomadik.c

+1 −1
Original line number Diff line number Diff line
@@ -935,7 +935,7 @@ static int __devinit nmk_i2c_probe(struct platform_device *pdev) 
	}



	dev->irq = platform_get_irq(pdev, 0);

	ret = request_irq(dev->irq, i2c_irq_handler, IRQF_DISABLED,

	ret = request_irq(dev->irq, i2c_irq_handler, 0,

				DRIVER_NAME, dev);

	if (ret) {

		dev_err(&pdev->dev, "cannot claim the irq %d\n", dev->irq);

drivers/i2c/busses/i2c-nuc900.c

+1 −1
Original line number Diff line number Diff line
@@ -610,7 +610,7 @@ static int __devinit nuc900_i2c_probe(struct platform_device *pdev) 
		goto err_iomap;

	}



	ret = request_irq(i2c->irq, nuc900_i2c_irq, IRQF_DISABLED | IRQF_SHARED,

	ret = request_irq(i2c->irq, nuc900_i2c_irq, IRQF_SHARED,

			  dev_name(&pdev->dev), i2c);



	if (ret != 0) {