Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42b276a2 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf top: Decay periods in callchains 



It missed to decay periods in callchains when decaying hist entries.
This resulted in more than 100 percent overhead in callchains in the
fractal style output.

Reported-by: default avatarArnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1451963160-17196-1-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 915b0882

tools/perf/util/callchain.c

+28 −0
Original line number Diff line number Diff line
@@ -925,6 +925,34 @@ void free_callchain(struct callchain_root *root) 
	free_callchain_node(&root->node);

}



static u64 decay_callchain_node(struct callchain_node *node)

{

	struct callchain_node *child;

	struct rb_node *n;

	u64 child_hits = 0;



	n = rb_first(&node->rb_root_in);

	while (n) {

		child = container_of(n, struct callchain_node, rb_node_in);



		child_hits += decay_callchain_node(child);

		n = rb_next(n);

	}



	node->hit = (node->hit * 7) / 8;

	node->children_hit = child_hits;



	return node->hit;

}



void decay_callchain(struct callchain_root *root)

{

	if (!symbol_conf.use_callchain)

		return;



	decay_callchain_node(&root->node);

}



int callchain_node__make_parent_list(struct callchain_node *node)

{

	struct callchain_node *parent = node->parent;

tools/perf/util/callchain.h

+1 −0
Original line number Diff line number Diff line
@@ -253,6 +253,7 @@ int callchain_node__fprintf_value(struct callchain_node *node, 
				  FILE *fp, u64 total);



void free_callchain(struct callchain_root *root);

void decay_callchain(struct callchain_root *root);

int callchain_node__make_parent_list(struct callchain_node *node);



#endif	/* __PERF_CALLCHAIN_H */

tools/perf/util/hist.c

+1 −0
Original line number Diff line number Diff line
@@ -254,6 +254,7 @@ static bool hists__decay_entry(struct hists *hists, struct hist_entry *he) 
	he_stat__decay(&he->stat);

	if (symbol_conf.cumulate_callchain)

		he_stat__decay(he->stat_acc);

	decay_callchain(he->callchain);



	diff = prev_period - he->stat.period;