Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4237e0d3 authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds
Browse files

proc: less LOCK operations during lookup 



Pseudo-code for lookup effectively is:

	LOCK kernel
	LOCK proc_subdir_lock
		find PDE
		UNLOCK proc_subdir_lock

		get inode

		LOCK proc_subdir_lock
		goto unlock
	UNLOCK proc_subdir_lock
	UNLOCK kernel

We can get rid of LOCK/UNLOCK pair after getting inode simply by jumping
to unlock_kernel() directly.

Signed-off-by: default avatarAlexey Dobriyan <adobriyan@sw.ru>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5b3fe63b

fs/proc/generic.c

+2 −2
Original line number Diff line number Diff line
@@ -406,12 +406,12 @@ struct dentry *proc_lookup(struct inode * dir, struct dentry *dentry, struct nam 
				spin_unlock(&proc_subdir_lock);

				error = -EINVAL;

				inode = proc_get_inode(dir->i_sb, ino, de);

				spin_lock(&proc_subdir_lock);

				break;

				goto out_unlock;

			}

		}

	}

	spin_unlock(&proc_subdir_lock);

out_unlock:

	unlock_kernel();



	if (inode) {