Commit 41f03a00 authored Mar 03, 2015 by Kamil Debski Committed by Mauro Carvalho Chehab Mar 04, 2015

[media] s5p-mfc: Fix NULL pointer dereference caused by not set q->lock



The patch "media: s5p-mfc: use vb2_ops_wait_prepare/finish helper"
(654a731b) introduced a kernel panic.
The q->lock was set for just one queue, the other was not set thus causing
a NULL pointer dereference.

Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent f7cbd688

drivers/media/platform/s5p-mfc/s5p_mfc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -833,6 +833,7 @@ static int s5p_mfc_open(struct file *file)
		q->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
		q->io_modes = VB2_MMAP;
		q->drv_priv = &ctx->fh;
		q->lock = &dev->mfc_mutex;
		if (vdev == dev->vfd_dec) {
		q->io_modes = VB2_MMAP;
		q->ops = get_dec_queue_ops();