Commit 41cfcf37 authored Nov 04, 2021 by Chengfeng Ye Committed by Greg Kroah-Hartman Jan 27, 2022

crypto: qce - fix uaf on qce_ahash_register_one



[ Upstream commit b4cb4d31631912842eb7dce02b4350cbb7562d5e ]

Pointer base points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing base before free tmpl.

Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 050ba775

drivers/crypto/qce/sha.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -544,8 +544,8 @@ static int qce_ahash_register_one(const struct qce_ahash_def *def,

		ret = crypto_register_ahash(alg);
		if (ret) {
		kfree(tmpl);
		dev_err(qce->dev, "%s registration failed\n", base->cra_name);
		kfree(tmpl);
		return ret;
		}