Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 419f00cb authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

can: softing_cs: softingcs_probe(): fix memleak on registration failure 

commit ced4913efb0acc844ed65cc01d091a85d83a2082 upstream.

In case device registration fails during probe, the driver state and
the embedded platform device structure needs to be freed using
platform_device_put() to properly free all resources (e.g. the device
name).

Fixes: 0a0b7a5f ("can: add driver for Softing card")
Link: https://lore.kernel.org/all/20211222104843.6105-1-johan@kernel.org


Cc: stable@vger.kernel.org # 2.6.38
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 05bcdfb1

drivers/net/can/softing/softing_cs.c

+1 −1
Original line number Diff line number Diff line
@@ -304,7 +304,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia) 
	return 0;



platform_failed:

	kfree(dev);

	platform_device_put(pdev);

mem_failed:

pcmcia_bad:

pcmcia_failed: