Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4190c220 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: adv_pci_dio: remove board reset during (*detach) 



The board reset function disables and clears all interrupts. It also
resets all the digital output channels to 0.

Interrupts are not used by this driver so the disable/clear during the
(*detach) is not necessary.

Reseting all the digital outputs to 0 might not be desired depending
on what the outputs are connected to.

Remove the board reset and just use comedi_pci_detach() directly for
the driver (*detach).

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e01b70bc

drivers/staging/comedi/drivers/adv_pci_dio.c

+1 −8
Original line number Diff line number Diff line
@@ -548,18 +548,11 @@ static int pci_dio_auto_attach(struct comedi_device *dev, 
	return 0;

}



static void pci_dio_detach(struct comedi_device *dev)

{

	if (dev->iobase)

		pci_dio_reset(dev);

	comedi_pci_detach(dev);

}



static struct comedi_driver adv_pci_dio_driver = {

	.driver_name	= "adv_pci_dio",

	.module		= THIS_MODULE,

	.auto_attach	= pci_dio_auto_attach,

	.detach		= pci_dio_detach,

	.detach		= comedi_pci_detach,

};



static int adv_pci_dio_pci_probe(struct pci_dev *dev,