Commit 41849d49 authored Nov 21, 2015 by Lars-Peter Clausen Committed by Brian Norris Dec 04, 2015

mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq()



Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
 free_irq(irq, ...);
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent d6af2694

drivers/mtd/nand/r852.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -980,7 +980,6 @@ static void r852_remove(struct pci_dev *pci_dev)

		/* Stop interrupts */
		r852_disable_irqs(dev);
		synchronize_irq(dev->irq);
		free_irq(dev->irq, dev);

		/* Cleanup */