Commit 417b57b3 authored Aug 06, 2009 by Roel Kluin Committed by Greg Kroah-Hartman Sep 23, 2009

USB: gadget: Read buffer overflow



Check whether index is within bounds before testing the element.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent d0defb85

drivers/usb/gadget/composite.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -602,7 +602,7 @@ static int get_string(struct usb_composite_dev *cdev,
	}		}
	}		}

	for (len = 0; s->wData[len] && len <= 126; len++)		for (len = 0; len <= 126 && s->wData[len]; len++)
	continue;		continue;
	if (!len)		if (!len)
	return -EINVAL;		return -EINVAL;