Commit 4174ecd7 authored Dec 20, 2013 by Sergei Shtylyov Committed by David S. Miller Dec 19, 2013

sh_eth: do not reset PHY needlessly

There's no need anymore to call phy_init_hw() to reset/resume the PHY from the
driver, as the call chain in phylib already has reached it, and so reset/resumed
the PHY (even resuming it twice). This duplicate reset is not only needless, it
e.g. clears the PHY's interrupt enables just setup by phylib and so prevents the
expected IRQs from the PHY.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 18be099b

drivers/net/ethernet/renesas/sh_eth.c

+0 −5

Original line number	Original line	Diff line number	Diff line
	@@ -1703,11 +1703,6 @@ static int sh_eth_phy_start(struct net_device *ndev)
	if (ret)		if (ret)
	return ret;		return ret;

	/* reset phy - this also wakes it from PDOWN */
	ret = phy_init_hw(mdp->phydev);
	if (ret)
	return ret;

	phy_start(mdp->phydev);		phy_start(mdp->phydev);

	return 0;		return 0;