Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41033f02 authored by Neil Horman's avatar Neil Horman Committed by David S. Miller
Browse files

snmp: Remove duplicate OUTMCAST stat increment 



the OUTMCAST stat is double incremented, getting bumped once in the mcast code
itself, and again in the common ip output path.  Remove the mcast bump, as its
not needed

Validated by the reporter, with good results

Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Reported-by: default avatarClaus Jensen <claus.jensen@microsemi.com>
CC: Claus Jensen <claus.jensen@microsemi.com>
CC: David Miller <davem@davemloft.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7750130d

net/ipv6/mcast.c

+0 −2
Original line number Diff line number Diff line
@@ -1651,7 +1651,6 @@ static void mld_sendpack(struct sk_buff *skb) 
	if (!err) {

		ICMP6MSGOUT_INC_STATS(net, idev, ICMPV6_MLD2_REPORT);

		ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS);

		IP6_UPD_PO_STATS(net, idev, IPSTATS_MIB_OUTMCAST, payload_len);

	} else {

		IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS);

	}
@@ -2015,7 +2014,6 @@ static void igmp6_send(struct in6_addr *addr, struct net_device *dev, int type) 
	if (!err) {

		ICMP6MSGOUT_INC_STATS(net, idev, type);

		ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS);

		IP6_UPD_PO_STATS(net, idev, IPSTATS_MIB_OUTMCAST, full_len);

	} else

		IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS);