Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4040c415 authored by Jean Delvare's avatar Jean Delvare Committed by Mark M. Hoffman
Browse files

hwmon: (w83l785ts) Don't ask the user to report failures 



There's nothing we can do about read errors on the W83L785TS-S, so
don't ask the user to report them.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarMark M. Hoffman <mhoffman@lightlink.com>
parent 4b119e21

Documentation/hwmon/w83l785ts

+2 −1
Original line number Diff line number Diff line
@@ -33,7 +33,8 @@ Known Issues 
------------



On some systems (Asus), the BIOS is known to interfere with the driver

and cause read errors. The driver will retry a given number of times

and cause read errors. Or maybe the W83L785TS-S chip is simply unreliable,

we don't really know. The driver will retry a given number of times

(5 by default) and then give up, returning the old value (or 0 if

there is no old value). It seems to work well enough so that you should

not notice anything. Thanks to James Bolt for helping test this feature.

drivers/hwmon/w83l785ts.c

+2 −2
Original line number Diff line number Diff line
@@ -301,8 +301,8 @@ static u8 w83l785ts_read_value(struct i2c_client *client, u8 reg, u8 defval) 
		msleep(i);

	}



	dev_err(&client->dev, "Couldn't read value from register 0x%02x. "

		"Please report.\n", reg);

	dev_err(&client->dev, "Couldn't read value from register 0x%02x.\n",

		reg);

	return defval;

}