Commit 3f50a690 authored Nov 15, 2015 by Eliad Peller Committed by Emmanuel Grumbach Dec 13, 2015

iwlwifi: mvm: check iwl_mvm_wowlan_config_key_params() return value



commit 9a4c830007817e ("iwlwifi: mvm: refactor d3 key
update functions") refactored some code into
iwl_mvm_wowlan_config_key_params() function, but the
return value was never checked, and not all the function
flows returned valid values. fix it.

Fixes: ac8ef0ce ("iwlwifi: mvm: refactor d3 key update functions")
Signed-off-by: Eliad Peller <eliadx.peller@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

parent 305d236e

drivers/net/wireless/intel/iwlwifi/mvm/d3.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -917,6 +917,7 @@ int iwl_mvm_wowlan_config_key_params(struct iwl_mvm *mvm,
		if (ret)
		goto out;
		}
		ret = 0;
		out:
		kfree(key_data.rsc_tsc);
		return ret;
		@@ -946,8 +947,11 @@ iwl_mvm_wowlan_config(struct iwl_mvm *mvm,
		* that isn't really a problem though.
		*/
		mutex_unlock(&mvm->mutex);
		iwl_mvm_wowlan_config_key_params(mvm, vif, true, CMD_ASYNC);
		ret = iwl_mvm_wowlan_config_key_params(mvm, vif, true,
		CMD_ASYNC);
		mutex_lock(&mvm->mutex);
		if (ret)
		return ret;
		}

		ret = iwl_mvm_send_cmd_pdu(mvm, WOWLAN_CONFIGURATION, 0,