Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f2728bd authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf report: Add option to show total period 

Just like --show-nr-samples, to help in diagnosing problems in the
tools.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-1lr7ejdjfvy2uwy2wkmatcpq@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent ef9dfe6e

tools/perf/Documentation/perf-report.txt

+2 −0
Original line number Diff line number Diff line
@@ -137,6 +137,8 @@ OPTIONS 
-M::

--disassembler-style=:: Set disassembler style for objdump.



--show-total-period:: Show a column with the sum of periods.



SEE ALSO

--------

linkperf:perf-stat[1]

tools/perf/builtin-report.c

+2 −0
Original line number Diff line number Diff line
@@ -486,6 +486,8 @@ static const struct option options[] = { 
	OPT_STRING('c', "cpu", &cpu_list, "cpu", "list of cpus to profile"),

	OPT_STRING('M', "disassembler-style", &disassembler_style, "disassembler style",

		   "Specify disassembler style (e.g. -M intel for intel syntax)"),

	OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period,

		    "Show a column with the sum of periods"),

	OPT_END()

};

tools/perf/util/hist.c

+19 −0
Original line number Diff line number Diff line
@@ -664,6 +664,13 @@ int hist_entry__snprintf(struct hist_entry *self, char *s, size_t size, 
			ret += snprintf(s + ret, size - ret, "%11" PRIu64, nr_events);

	}



	if (symbol_conf.show_total_period) {

		if (sep)

			ret += snprintf(s + ret, size - ret, "%c%" PRIu64, *sep, period);

		else

			ret += snprintf(s + ret, size - ret, " %12" PRIu64, period);

	}



	if (pair_hists) {

		char bf[32];

		double old_percent = 0, new_percent = 0, diff;
@@ -770,6 +777,13 @@ size_t hists__fprintf(struct hists *hists, struct hists *pair, 
			fputs("  Samples  ", fp);

	}



	if (symbol_conf.show_total_period) {

		if (sep)

			ret += fprintf(fp, "%cPeriod", *sep);

		else

			ret += fprintf(fp, "   Period    ");

	}



	if (symbol_conf.show_cpu_utilization) {

		if (sep) {

			ret += fprintf(fp, "%csys", *sep);
@@ -834,6 +848,8 @@ size_t hists__fprintf(struct hists *hists, struct hists *pair, 
	fprintf(fp, "# ........");

	if (symbol_conf.show_nr_samples)

		fprintf(fp, " ..........");

	if (symbol_conf.show_total_period)

		fprintf(fp, " ............");

	if (pair) {

		fprintf(fp, " ..........");

		if (show_displacement)
@@ -917,6 +933,9 @@ unsigned int hists__sort_list_width(struct hists *hists) 
	if (symbol_conf.show_nr_samples)

		ret += 11;



	if (symbol_conf.show_total_period)

		ret += 13;



	list_for_each_entry(se, &hist_entry__sort_list, list)

		if (!se->elide)

			ret += 2 + hists__col_len(hists, se->se_width_idx);

tools/perf/util/symbol.h

+1 −0
Original line number Diff line number Diff line
@@ -72,6 +72,7 @@ struct symbol_conf { 
			use_modules,

			sort_by_name,

			show_nr_samples,

			show_total_period,

			use_callchain,

			exclude_other,

			show_cpu_utilization,