Commit 3f0bdb2e authored Jun 19, 2015 by Jacob Keller Committed by Jeff Kirsher Sep 15, 2015

fm10k: allow creation of VLAN interfaces even while down



We re-sync upon going up, so there is little reason to worry about not
syncing immediately with switch. This prevents an error that occurs if
you add a VLAN interface while down.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 0ff36676

drivers/net/ethernet/intel/fm10k/fm10k_netdev.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -779,6 +779,12 @@ static int fm10k_update_vid(struct net_device *netdev, u16 vid, bool set)
		if (!set && vid == hw->mac.default_vid)
		return 0;

		/* Do not throw an error if the interface is down. We will sync once
		* we come up
		*/
		if (test_bit(__FM10K_DOWN, &interface->state))
		return 0;

		fm10k_mbx_lock(interface);

		/* only need to update the VLAN if not in promiscuous mode */