Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3eb4351a authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Jiri Kosina
Browse files

HID: input: call input_sync() when automatically releasing a key 



We need to emit EV_SYN/SYN_REPORT between key press and release, otherwise
userspace is allowed to "swallow" the event.

[jkosina@suse.com: Dmitry says that he's observing this behavior with
 Plantronics headset]

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 67e123ff

drivers/hid/hid-input.c

+4 −1
Original line number Diff line number Diff line
@@ -1163,9 +1163,12 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct 


	input_event(input, usage->type, usage->code, value);



	if ((field->flags & HID_MAIN_ITEM_RELATIVE) && (usage->type == EV_KEY))

	if ((field->flags & HID_MAIN_ITEM_RELATIVE) &&

	    usage->type == EV_KEY && value) {

		input_sync(input);

		input_event(input, usage->type, usage->code, 0);

	}

}



void hidinput_report_event(struct hid_device *hid, struct hid_report *report)

{