Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e2c1592 authored by Johannes Berg's avatar Johannes Berg
Browse files

iwlwifi: clarify NOCOPY/DUP documentation 



Clarify the documentation to indicate that these
flags can only be used at the end, i.e. after them
a copy TFD (no flags set) is invalid.

Reported-by: default avatarInbal Hacohen <inbal.hacohen@intel.com>
Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent f4feb8ac

drivers/net/wireless/iwlwifi/iwl-trans.h

+4 −1
Original line number Diff line number Diff line
@@ -225,10 +225,13 @@ struct iwl_device_cmd { 
 *	ring. The transport layer doesn't map the command's buffer to DMA, but

 *	rather copies it to an previously allocated DMA buffer. This flag tells

 *	the transport layer not to copy the command, but to map the existing

 *	buffer. This can save memcpy and is worth with very big comamnds.

 *	buffer (that is passed in) instead. This saves the memcpy and allows

 *	commands that are bigger than the fixed buffer to be submitted.

 *	Note that a TFD entry after a NOCOPY one cannot be a normal copied one.

 * @IWL_HCMD_DFL_DUP: Only valid without NOCOPY, duplicate the memory for this

 *	chunk internally and free it again after the command completes. This

 *	can (currently) be used only once per command.

 *	Note that a TFD entry after a DUP one cannot be a normal copied one.

 */

enum iwl_hcmd_dataflag {

	IWL_HCMD_DFL_NOCOPY	= BIT(0),