Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3def9ad6 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Mauro Carvalho Chehab
Browse files

[media] nuvoton-cir: use request_muxed_region for accessing EFM registers 



The two EFM ioports are accessed by drivers for other parts of the Nuvoton
Super-IO chips too. Therefore access to these ioports needs to be
protected by using request_muxed_region (like it's implemented e.g. in
hwmon/nct6775 already).

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent a73cfe52

drivers/media/rc/nuvoton-cir.c

+8 −1
Original line number Diff line number Diff line
@@ -80,17 +80,24 @@ static inline void nvt_clear_reg_bit(struct nvt_dev *nvt, u8 val, u8 reg) 
}



/* enter extended function mode */

static inline void nvt_efm_enable(struct nvt_dev *nvt)

static inline int nvt_efm_enable(struct nvt_dev *nvt)

{

	if (!request_muxed_region(nvt->cr_efir, 2, NVT_DRIVER_NAME))

		return -EBUSY;



	/* Enabling Extended Function Mode explicitly requires writing 2x */

	outb(EFER_EFM_ENABLE, nvt->cr_efir);

	outb(EFER_EFM_ENABLE, nvt->cr_efir);



	return 0;

}



/* exit extended function mode */

static inline void nvt_efm_disable(struct nvt_dev *nvt)

{

	outb(EFER_EFM_DISABLE, nvt->cr_efir);



	release_region(nvt->cr_efir, 2);

}



/*