Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cf080a7 authored by Tadeusz Struk's avatar Tadeusz Struk Committed by Herbert Xu
Browse files

crypto: qat - fix invalid check for RSA keylen in fips mode 



The condition checking allowed key length was invalid.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>

Signed-off-by: default avatarTadeusz Struk <tadeusz.struk@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent a9d4f82f

drivers/crypto/qat/qat_common/qat_asym_algs.c

+2 −2
Original line number Diff line number Diff line
@@ -443,7 +443,7 @@ int qat_rsa_get_n(void *context, size_t hdrlen, unsigned char tag, 
	ctx->key_sz = vlen;

	ret = -EINVAL;

	/* In FIPS mode only allow key size 2K & 3K */

	if (fips_enabled && (ctx->key_sz != 256 || ctx->key_sz != 384)) {

	if (fips_enabled && (ctx->key_sz != 256 && ctx->key_sz != 384)) {

		pr_err("QAT: RSA: key size not allowed in FIPS mode\n");

		goto err;

	}
@@ -510,7 +510,7 @@ int qat_rsa_get_d(void *context, size_t hdrlen, unsigned char tag, 
		goto err;



	/* In FIPS mode only allow key size 2K & 3K */

	if (fips_enabled && (vlen != 256 || vlen != 384)) {

	if (fips_enabled && (vlen != 256 && vlen != 384)) {

		pr_err("QAT: RSA: key size not allowed in FIPS mode\n");

		goto err;

	}