Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cbf62df authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds
Browse files

checkpatch: handle EXPORT_SYMBOL for DEVICE_ATTR and similar 



Handly definitions similar to below.  The definition macro spits out a
symbol with a prefix.  Add matching of any identifier prefix:

    DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,
            ata_scsi_lpm_show, ata_scsi_lpm_put);
    EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy);

Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5eaa20b9

scripts/checkpatch.pl

+10 −1
Original line number Diff line number Diff line
@@ -1822,8 +1822,17 @@ sub process { 
		    !defined $suppress_export{$realline_next} &&

		    ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||

		     $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {

			# Handle definitions which produce identifiers with

			# a prefix:

			#   XXX(foo);

			#   EXPORT_SYMBOL(something_foo);

			my $name = $1;

			if ($stat !~ /(?:

			if ($stat =~ /^.([A-Z_]+)\s*\(\s*($Ident)/ &&

			    $name =~ /^${Ident}_$2/) {

#print "FOO C name<$name>\n";

				$suppress_export{$realline_next} = 1;



			} elsif ($stat !~ /(?:

				\n.}\s*$|

				^.DEFINE_$Ident\(\Q$name\E\)|

				^.DECLARE_$Ident\(\Q$name\E\)|