Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c24019d authored by Axel Lin's avatar Axel Lin Committed by Liam Girdwood
Browse files

regulator: Fix off-by-one value range checking for mc13xxx_regulator_get_voltage 



We use val as array index,
thus the valid value rangae for val should be 0 .. n_voltages-1.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent 6dc4efc6

drivers/regulator/mc13xxx-regulator-core.c

+1 −1
Original line number Diff line number Diff line
@@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev) 


	dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val);



	BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages);

	BUG_ON(val >= mc13xxx_regulators[id].desc.n_voltages);



	return mc13xxx_regulators[id].voltages[val];

}