Commit 3c0c25b9 authored Apr 13, 2006 by Moore, Eric Committed by James Bottomley Apr 14, 2006

[SCSI] mptfusion - fix panic in mptsas_slave_configure



Driver panic when RAID logical volume was present when driver
loaded, or when a RAID logical volume was created on the fly.

This issue was created in due to recent scsi_transport_sas change,
when sas_read_port_mode_page was added into the mptsas drivers
slave_config entry point.

This new API expects that all sdev's to be assocated to an rphy, however
that is not the case for logical volumes, as they are created using
scsi_add_device, instead of sas_rphy_add().

Signed-off-by: Eric Moore <Eric.Moore@lsil.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent 1e08dcb3

drivers/message/fusion/mptsas.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -366,6 +366,14 @@ mptsas_sas_enclosure_pg0(MPT_ADAPTER ioc, struct mptsas_enclosure enclosure,
		static int
		mptsas_slave_configure(struct scsi_device *sdev)
		{
		struct Scsi_Host *host = sdev->host;
		MPT_SCSI_HOST hd = (MPT_SCSI_HOST )host->hostdata;

		/*
		* RAID volumes placed beyond the last expected port.
		* Ignore sending sas mode pages in that case..
		*/
		if (sdev->channel < hd->ioc->num_ports)
		sas_read_port_mode_page(sdev);

		return mptscsih_slave_configure(sdev);