Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b6571c1 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

Btrfs: don't BUG_ON() in btrfs_orphan_add 



This is just a screwup for developers, so change it to an ASSERT() so developers
notice when things go wrong and deal with the error appropriately if ASSERT()
isn't enabled.  Thanks,

Signed-off-by: default avatarJosef Bacik <jbacik@fb.com>
Reviewed-by: default avatarMark Fasheh <mfasheh@suse.de>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 64c12921

fs/btrfs/inode.c

+10 −1
Original line number Diff line number Diff line
@@ -3271,7 +3271,16 @@ int btrfs_orphan_add(struct btrfs_trans_handle *trans, struct inode *inode) 
	/* grab metadata reservation from transaction handle */

	if (reserve) {

		ret = btrfs_orphan_reserve_metadata(trans, inode);

		BUG_ON(ret); /* -ENOSPC in reservation; Logic error? JDM */

		ASSERT(!ret);

		if (ret) {

			atomic_dec(&root->orphan_inodes);

			clear_bit(BTRFS_INODE_ORPHAN_META_RESERVED,

				  &BTRFS_I(inode)->runtime_flags);

			if (insert)

				clear_bit(BTRFS_INODE_HAS_ORPHAN_ITEM,

					  &BTRFS_I(inode)->runtime_flags);

			return ret;

		}

	}



	/* insert an orphan item to track this unlinked/truncated file */