Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b5e11d7 authored by David Binder's avatar David Binder Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorhba: switch success handling to error handling 



Addresses code audit feeback to switch from success handling to error
handling in visorhba_main.c/process_disk_notify().

Signed-off-by: default avatarDavid Binder <david.binder@unisys.com>
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 825157ae

drivers/staging/unisys/visorhba/visorhba_main.c

+9 −8
Original line number Diff line number Diff line
@@ -950,7 +950,9 @@ static void process_disk_notify(struct Scsi_Host *shost, 
	struct diskaddremove *dar;



	dar = kzalloc(sizeof(*dar), GFP_ATOMIC);

	if (dar) {

	if (!dar)

		return;



	dar->add = cmdrsp->disknotify.add;

	dar->shost = shost;

	dar->channel = cmdrsp->disknotify.channel;
@@ -958,7 +960,6 @@ static void process_disk_notify(struct Scsi_Host *shost, 
	dar->lun = cmdrsp->disknotify.lun;

	queue_disk_add_remove(dar);

}

}



/**

 *	drain_queue - pull responses out of iochannel