Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3af33637 authored by Dan Carpenter's avatar Dan Carpenter Committed by Roland Dreier
Browse files

IB/srpt: Fix ERR_PTR() vs. NULL checking confusion 



transport_init_session() and target_fabric_configfs_init() don't
return NULL pointers, they only return ERR_PTRs or valid pointers.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent ebfded8c

drivers/infiniband/ulp/srpt/ib_srpt.c

+3 −3
Original line number Diff line number Diff line
@@ -2595,7 +2595,7 @@ static int srpt_cm_req_recv(struct ib_cm_id *cm_id, 
	}



	ch->sess = transport_init_session();

	if (!ch->sess) {

	if (IS_ERR(ch->sess)) {

		rej->reason = __constant_cpu_to_be32(

				SRP_LOGIN_REJ_INSUFFICIENT_RESOURCES);

		pr_debug("Failed to create session\n");
@@ -4009,10 +4009,10 @@ static int __init srpt_init_module(void) 
		goto out;

	}



	ret = -ENODEV;

	srpt_target = target_fabric_configfs_init(THIS_MODULE, "srpt");

	if (!srpt_target) {

	if (IS_ERR(srpt_target)) {

		printk(KERN_ERR "couldn't register\n");

		ret = PTR_ERR(srpt_target);

		goto out;

	}