Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3adc0bec authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by David S. Miller
Browse files

net: ethernet: cisco: enic: enic_dev: Remove some unused functions 



Removes some functions that are not used anywhere:
enic_dev_enable2_done() enic_dev_enable2() enic_dev_deinit_done()
enic_dev_init_prov2() enic_vnic_dev_deinit()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 50ab97d7

drivers/net/ethernet/cisco/enic/enic_dev.c

+0 −56
Original line number Diff line number Diff line
@@ -177,40 +177,6 @@ int enic_dev_intr_coal_timer_info(struct enic *enic) 
	return err;

}



int enic_vnic_dev_deinit(struct enic *enic)

{

	int err;



	spin_lock_bh(&enic->devcmd_lock);

	err = vnic_dev_deinit(enic->vdev);

	spin_unlock_bh(&enic->devcmd_lock);



	return err;

}



int enic_dev_init_prov2(struct enic *enic, struct vic_provinfo *vp)

{

	int err;



	spin_lock_bh(&enic->devcmd_lock);

	err = vnic_dev_init_prov2(enic->vdev,

		(u8 *)vp, vic_provinfo_size(vp));

	spin_unlock_bh(&enic->devcmd_lock);



	return err;

}



int enic_dev_deinit_done(struct enic *enic, int *status)

{

	int err;



	spin_lock_bh(&enic->devcmd_lock);

	err = vnic_dev_deinit_done(enic->vdev, status);

	spin_unlock_bh(&enic->devcmd_lock);



	return err;

}



/* rtnl lock is held */

int enic_vlan_rx_add_vid(struct net_device *netdev, __be16 proto, u16 vid)

{
@@ -237,28 +203,6 @@ int enic_vlan_rx_kill_vid(struct net_device *netdev, __be16 proto, u16 vid) 
	return err;

}



int enic_dev_enable2(struct enic *enic, int active)

{

	int err;



	spin_lock_bh(&enic->devcmd_lock);

	err = vnic_dev_enable2(enic->vdev, active);

	spin_unlock_bh(&enic->devcmd_lock);



	return err;

}



int enic_dev_enable2_done(struct enic *enic, int *status)

{

	int err;



	spin_lock_bh(&enic->devcmd_lock);

	err = vnic_dev_enable2_done(enic->vdev, status);

	spin_unlock_bh(&enic->devcmd_lock);



	return err;

}



int enic_dev_status_to_errno(int devcmd_status)

{

	switch (devcmd_status) {

drivers/net/ethernet/cisco/enic/enic_dev.h

+0 −5
Original line number Diff line number Diff line
@@ -55,11 +55,6 @@ int enic_dev_set_ig_vlan_rewrite_mode(struct enic *enic); 
int enic_dev_enable(struct enic *enic);

int enic_dev_disable(struct enic *enic);

int enic_dev_intr_coal_timer_info(struct enic *enic);

int enic_vnic_dev_deinit(struct enic *enic);

int enic_dev_init_prov2(struct enic *enic, struct vic_provinfo *vp);

int enic_dev_deinit_done(struct enic *enic, int *status);

int enic_dev_enable2(struct enic *enic, int arg);

int enic_dev_enable2_done(struct enic *enic, int *status);

int enic_dev_status_to_errno(int devcmd_status);



#endif /* _ENIC_DEV_H_ */