Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ac38d26 authored by Gregory Herrero's avatar Gregory Herrero Committed by Felipe Balbi
Browse files

usb: dwc2: host: ensure filling of isoc desc is correctly done 



Increment qtd->isoc_frame_index_last before testing it, else below
check will never be true and IOC (Interrupt On Complete) bit for
last frame will never be set in descriptor status.

  /* Set IOC for each descriptor corresponding to last frame of URB */
  if (qtd->isoc_frame_index_last == qtd->urb->packet_count)
	dma_desc->status |= HOST_DMA_IOC;

Acked-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarGregory Herrero <gregory.herrero@intel.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 4cee4fa5

drivers/usb/dwc2/hcd_ddma.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -524,14 +524,15 @@ static void dwc2_fill_host_isoc_dma_desc(struct dwc2_hsotg *hsotg, 
	dma_desc->status = qh->n_bytes[idx] << HOST_DMA_ISOC_NBYTES_SHIFT &

	dma_desc->status = qh->n_bytes[idx] << HOST_DMA_ISOC_NBYTES_SHIFT &

			   HOST_DMA_ISOC_NBYTES_MASK;

			   HOST_DMA_ISOC_NBYTES_MASK;





	qh->ntd++;

	qtd->isoc_frame_index_last++;



#ifdef ISOC_URB_GIVEBACK_ASAP

#ifdef ISOC_URB_GIVEBACK_ASAP

	/* Set IOC for each descriptor corresponding to last frame of URB */

	/* Set IOC for each descriptor corresponding to last frame of URB */

	if (qtd->isoc_frame_index_last == qtd->urb->packet_count)

	if (qtd->isoc_frame_index_last == qtd->urb->packet_count)

		dma_desc->status |= HOST_DMA_IOC;

		dma_desc->status |= HOST_DMA_IOC;

#endif

#endif





	qh->ntd++;

	qtd->isoc_frame_index_last++;

}

}





static void dwc2_init_isoc_dma_desc(struct dwc2_hsotg *hsotg,

static void dwc2_init_isoc_dma_desc(struct dwc2_hsotg *hsotg,