Commit 3a6d1bc4 authored Apr 17, 2009 by Jesse Brandeburg Committed by David S. Miller Apr 20, 2009

ixgb: fix link down initial state



As reported by Andrew Lutomirski <amluto@gmail.com>

All the intel wired ethernet drivers were calling netif_carrier_off
and netif_stop_queue (or variants) before calling register_netdevice

This is incorrect behavior as was pointed out by davem, and causes
ifconfig and friends to report a strange state before first link
after the driver was loaded, since without a netif_carrier_off, the stack
assumes carrier_on, but before register_netdev, netlink messages are not
sent out telling link state.

This apparently confused *some* versions of networkmanager.

in addition this driver appeared to need a netif_start_queue at
the end of open.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reported-by: Andrew Lutomirski <amluto@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 54386467

drivers/net/ixgb/ixgb_main.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -471,10 +471,8 @@ ixgb_probe(struct pci_dev pdev, const struct pci_device_id ent)
		if (err)
		goto err_register;

		/* we're going to reset, so assume we have no link for now */

		/* carrier off reporting is important to ethtool even BEFORE open */
		netif_carrier_off(netdev);
		netif_stop_queue(netdev);

		DPRINTK(PROBE, INFO, "Intel(R) PRO/10GbE Network Connection\n");
		ixgb_check_options(adapter);
		@@ -592,6 +590,8 @@ ixgb_open(struct net_device *netdev)
		if (err)
		goto err_setup_tx;

		netif_carrier_off(netdev);

		/* allocate receive descriptors */

		err = ixgb_setup_rx_resources(adapter);
		@@ -602,6 +602,8 @@ ixgb_open(struct net_device *netdev)
		if (err)
		goto err_up;

		netif_start_queue(netdev);

		return 0;

		err_up: