Commit 399c168a authored Oct 22, 2016 by David Wu Committed by Wolfram Sang Oct 25, 2016

i2c: rk3x: Give the tuning value 0 during rk3x_i2c_v0_calc_timings



We found a bug that i2c transfer sometimes failed on 3066a board with
stabel-4.8, the con register would be updated by uninitialized tuning
value, it made the i2c transfer failed.

So give the tuning value to be zero during rk3x_i2c_v0_calc_timings.

Signed-off-by: David Wu <david.wu@rock-chips.com>
Tested-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org

parent ae824f00

drivers/i2c/busses/i2c-rk3x.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -694,6 +694,8 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
		t_calc->div_low--;
		t_calc->div_high--;

		/* Give the tuning value 0, that would not update con register */
		t_calc->tuning = 0;
		/* Maximum divider supported by hw is 0xffff */
		if (t_calc->div_low > 0xffff) {
		t_calc->div_low = 0xffff;