Commit 399566f8 authored Jan 16, 2017 by Jack Morgenstein Committed by Greg Kroah-Hartman Jul 05, 2017

net/mlx4_core: Eliminate warning messages for SRQ_LIMIT under SRIOV




[ Upstream commit 9577b174cd0323d287c994ef0891db71666d0765 ]

When running SRIOV, warnings for SRQ LIMIT events flood the Hypervisor's
message log when (correct, normally operating) apps use SRQ LIMIT events
as a trigger to post WQEs to SRQs.

Add more information to the existing debug printout for SRQ_LIMIT, and
output the warning messages only for the SRQ CATAS ERROR event.

Fixes: acba2420 ("mlx4_core: Add wrapper functions and comm channel and slave event support to EQs")
Fixes: e0debf9c ("mlx4_core: Reduce warning message for SRQ_LIMIT event to debug level")
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b6f75b98

drivers/net/ethernet/mellanox/mlx4/eq.c

+14 −9

Original line number	Diff line number	Diff line
		@@ -554,8 +554,9 @@ static int mlx4_eq_int(struct mlx4_dev dev, struct mlx4_eq eq)
		break;

		case MLX4_EVENT_TYPE_SRQ_LIMIT:
		mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT\n",
		__func__);
		mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT. srq_no=0x%x, eq 0x%x\n",
		__func__, be32_to_cpu(eqe->event.srq.srqn),
		eq->eqn);
		case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR:
		if (mlx4_is_master(dev)) {
		/* forward only to slave owning the SRQ */
		@@ -570,12 +571,16 @@ static int mlx4_eq_int(struct mlx4_dev dev, struct mlx4_eq eq)
		eq->eqn, eq->cons_index, ret);
		break;
		}
		if (eqe->type ==
		MLX4_EVENT_TYPE_SRQ_CATAS_ERROR)
		mlx4_warn(dev, "%s: slave:%d, srq_no:0x%x, event: %02x(%02x)\n",
		__func__, slave,
		be32_to_cpu(eqe->event.srq.srqn),
		eqe->type, eqe->subtype);

		if (!ret && slave != dev->caps.function) {
		if (eqe->type ==
		MLX4_EVENT_TYPE_SRQ_CATAS_ERROR)
		mlx4_warn(dev, "%s: sending event %02x(%02x) to slave:%d\n",
		__func__, eqe->type,
		eqe->subtype, slave);