Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38442040 authored by Richard Cochran's avatar Richard Cochran Committed by David S. Miller
Browse files

pxa168_eth: fix race in transmit path. 



Because the socket buffer is freed in the completion interrupt, it is not
safe to access it after submitting it to the hardware.

Cc: stable@kernel.org
Cc: Sachin Sanap <ssanap@marvell.com>
Cc: Zhangfei Gao <zgao6@marvell.com>
Cc: Philip Rakity <prakity@marvell.com>
Signed-off-by: default avatarRichard Cochran <richard.cochran@omicron.at>
Acked-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8ad2475e

drivers/net/pxa168_eth.c

+1 −1
Original line number Diff line number Diff line
@@ -1273,7 +1273,7 @@ static int pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev) 
	wmb();

	wrl(pep, SDMA_CMD, SDMA_CMD_TXDH | SDMA_CMD_ERD);



	stats->tx_bytes += skb->len;

	stats->tx_bytes += length;

	stats->tx_packets++;

	dev->trans_start = jiffies;

	if (pep->tx_ring_size - pep->tx_desc_count <= 1) {