Commit 3827d876 authored Nov 10, 2011 by Johan Hovold Committed by Greg Kroah-Hartman Nov 15, 2011

USB: serial: do not forward USB specific errors in open

Use usb_translate_errors() to map USB-specific errors to errors
appropriate for user space (ENOMEM, ENODEV and EIO) in open.

Currently almost all serial drivers simply forward error codes from the
stack (e.g. from usb_submit_urb()), but these codes often have
different meanings in user-space. Doing the mapping in usb-serial core
simplifies driver code and allows for more consistent error reporting.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 2c4d6bf2

drivers/usb/serial/usb-serial.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -260,6 +260,10 @@ static int serial_activate(struct tty_port tport, struct tty_struct tty)
		else
		retval = port->serial->type->open(tty, port);
		mutex_unlock(&serial->disc_mutex);

		if (retval < 0)
		retval = usb_translate_errors(retval);

		return retval;
		}