Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38184c52 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Morris
Browse files

selinux: fix error codes in cond_policydb_init() 



It's better to propagate the error code from avtab_init() instead of
returning -1 (-EPERM).  It turns out that avtab_init() never fails so
this patch doesn't change how the code runs but it's still a clean up.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarStephen D. Smalley <sds@tycho.nsa.gov>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent fc5c126e

security/selinux/ss/conditional.c

+6 −2
Original line number Diff line number Diff line
@@ -117,10 +117,14 @@ int evaluate_cond_node(struct policydb *p, struct cond_node *node) 


int cond_policydb_init(struct policydb *p)

{

	int rc;



	p->bool_val_to_struct = NULL;

	p->cond_list = NULL;

	if (avtab_init(&p->te_cond_avtab))

		return -1;



	rc = avtab_init(&p->te_cond_avtab);

	if (rc)

		return rc;



	return 0;

}