Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37fd1f66 authored by Thomas Falcon's avatar Thomas Falcon Committed by Greg Kroah-Hartman
Browse files

ibmveth: Convert multicast list size for little-endian system 



[ Upstream commit 66cf4710b23ab2adda11155684a2c8826f4fe732 ]

The ibm,mac-address-filters property defines the maximum number of
addresses the hypervisor's multicast filter list can support. It is
encoded as a big-endian integer in the OF device tree, but the virtual
ethernet driver does not convert it for use by little-endian systems.
As a result, the driver is not behaving as it should on affected systems
when a large number of multicast addresses are assigned to the device.

Reported-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 59d76363

drivers/net/ethernet/ibm/ibmveth.c

+5 −4
Original line number Diff line number Diff line
@@ -1557,7 +1557,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id) 
	struct net_device *netdev;

	struct ibmveth_adapter *adapter;

	unsigned char *mac_addr_p;

	unsigned int *mcastFilterSize_p;

	__be32 *mcastFilterSize_p;

	long ret;

	unsigned long ret_attr;
@@ -1579,8 +1579,9 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id) 
		return -EINVAL;

	}



	mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev,

						VETH_MCAST_FILTER_SIZE, NULL);

	mcastFilterSize_p = (__be32 *)vio_get_attribute(dev,

							VETH_MCAST_FILTER_SIZE,

							NULL);

	if (!mcastFilterSize_p) {

		dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE "

			"attribute\n");
@@ -1597,7 +1598,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id) 


	adapter->vdev = dev;

	adapter->netdev = netdev;

	adapter->mcastFilterSize = *mcastFilterSize_p;

	adapter->mcastFilterSize = be32_to_cpu(*mcastFilterSize_p);

	adapter->pool_config = 0;



	netif_napi_add(netdev, &adapter->napi, ibmveth_poll, 16);