Commit 37f7ec38 authored Jun 13, 2011 by Jesper Juhl Committed by Takashi Iwai Jun 14, 2011

ALSA: 6fire: Fix double-free bug in usb6fire_fw_ezusb_upload()



We have a double-free bug in
sound/usb/6fire/firmware.c::usb6fire_fw_ezusb_upload().
We already call release_firmware(fw) on line 258, so when we then do it
again after usb6fire_fw_ezusb_write() returns <0, we have a double-free.
Easily fixed by just removing the last call to release_firmware().

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 2308f4ad

sound/usb/6fire/firmware.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -270,7 +270,6 @@ static int usb6fire_fw_ezusb_upload(
		data = 0x00; /* resume ezusb cpu */
		ret = usb6fire_fw_ezusb_write(device, 0xa0, 0xe600, &data, 1);
		if (ret < 0) {
		release_firmware(fw);
		snd_printk(KERN_ERR PREFIX "unable to upload ezusb "
		"firmware %s: end message.\n", fwname);
		return ret;