Commit 37db2234 authored Jul 21, 2015 by Paul Gortmaker Committed by Greg Kroah-Hartman Jul 23, 2015

drivers/tty: make serial/suncore.c driver explicitly non-modular



The Kconfig for this driver is currently:

config SERIAL_SUNCORE
        bool

...meaning that it currently is not being built as a module by
anyone.  Lets remove the modular and unused code here, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We don't swap module.h for init.h since this file has init.h already.

We leave some tags like MODULE_LICENSE for documentation purposes, and
for the "git blame" value.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: sparclinux@vger.kernel.org
Cc: linux-serial@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1106d2db

drivers/tty/serial/suncore.c

+3 −8

Original line number	Original line	Diff line number	Diff line
	@@ -10,7 +10,6 @@
	* Copyright (C) 2002 David S. Miller (davem@redhat.com)		* Copyright (C) 2002 David S. Miller (davem@redhat.com)
	*/		*/

	#include <linux/module.h>
	#include <linux/kernel.h>		#include <linux/kernel.h>
	#include <linux/console.h>		#include <linux/console.h>
	#include <linux/tty.h>		#include <linux/tty.h>
	@@ -234,14 +233,10 @@ static int __init suncore_init(void)
	{		{
	return 0;		return 0;
	}		}
			device_initcall(suncore_init);

	static void __exit suncore_exit(void)		#if 0 /* ..def MODULE ; never supported as such */
	{
	}

	module_init(suncore_init);
	module_exit(suncore_exit);

	MODULE_AUTHOR("Eddie C. Dost, David S. Miller");		MODULE_AUTHOR("Eddie C. Dost, David S. Miller");
	MODULE_DESCRIPTION("Sun serial common layer");		MODULE_DESCRIPTION("Sun serial common layer");
	MODULE_LICENSE("GPL");		MODULE_LICENSE("GPL");
			#endif