Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3631f099 authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Shubham Talekar
Browse files

drm/modes: Skip invalid cmdline mode 



The named mode could be invalid and then cmdline parser misses to validate
mode's dimensions, happily adding 0x0 mode as a valid mode. One case where
this happens is NVIDIA Tegra devices that are using downstream bootloader
which adds "video=tegrafb" to the kernel's cmdline and thus upstream Tegra
DRM driver fails to probe because of the invalid mode.

Fixes: 3aeeb13d8996 ("drm/modes: Support modes names on the command line")
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDmitry Osipenko <digetx@gmail.com>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190709145151.23086-1-digetx@gmail.com


Patch-mainline: 20190709145151.23086-1-digetx@gmail.com @ 09/07/19, 02:51 p.m.
[stalek@codeaurora.org: drop changes for drm_modes.c since it is not require.].

Change-Id: I1d04c77f56bf207f5412bbbcc19b0c5e1d6fa845
Signed-off-by: default avatarShubham Talekar <stalek@codeaurora.org>
parent 99023f83

drivers/gpu/drm/drm_client_modeset.c

+2 −1
Original line number Diff line number Diff line
@@ -179,6 +179,7 @@ drm_connector_pick_cmdline_mode(struct drm_connector *connector) 


create_mode:

	mode = drm_mode_create_from_cmdline_mode(connector->dev, cmdline_mode);

	if (mode)

		list_add(&mode->head, &connector->modes);



	return mode;