Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35ffd08d authored by Markus Elfring's avatar Markus Elfring Committed by Michal Marek
Browse files

kconfig: Delete unnecessary checks before the function call "sym_calc_value" 



The sym_calc_value() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMichal Marek <mmarek@suse.com>
parent d770e558

scripts/kconfig/confdata.c

+2 −5
Original line number Diff line number Diff line
@@ -268,7 +268,6 @@ int conf_read_simple(const char *name, int def) 
			goto load;

		sym_add_change_count(1);

		if (!sym_defconfig_list) {

			if (modules_sym)

			sym_calc_value(modules_sym);

			return 1;

		}
@@ -404,8 +403,6 @@ int conf_read_simple(const char *name, int def) 
	}

	free(line);

	fclose(in);



	if (modules_sym)

	sym_calc_value(modules_sym);

	return 0;

}

scripts/kconfig/symbol.c

+1 −2
Original line number Diff line number Diff line
@@ -467,7 +467,6 @@ void sym_clear_all_valid(void) 
	for_all_symbols(i, sym)

		sym->flags &= ~SYMBOL_VALID;

	sym_add_change_count(1);

	if (modules_sym)

	sym_calc_value(modules_sym);

}