Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35e8901e authored by Robin H. Johnson's avatar Robin H. Johnson Committed by Jaroslav Kysela
Browse files

ALSA: HDA: hda_local: Less magic numbers. 



Explain some of the magic numbers I saw while trying to fix the AD1989 SPDIF
issue. Maybe should just use the expanded form directly in the verbs?

Signed-off-by: default avatarRobin H. Johnson <robbat2@gentoo.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
parent e8bfc6c1

sound/pci/hda/hda_local.h

+9 −6
Original line number Diff line number Diff line
@@ -368,12 +368,15 @@ int snd_hda_parse_pin_def_config(struct hda_codec *codec, 
#define AMP_OUT_UNMUTE	0xb000

#define AMP_OUT_ZERO	0xb000

/* pinctl values */

#define PIN_IN		0x20

#define PIN_VREF80	0x24

#define PIN_VREF50	0x21

#define PIN_OUT		0x40

#define PIN_HP		0xc0

#define PIN_HP_AMP	0x80

#define PIN_IN			(AC_PINCTL_IN_EN)

#define PIN_VREFHIZ	(AC_PINCTL_IN_EN | AC_PINCTL_VREF_HIZ)

#define PIN_VREF50		(AC_PINCTL_IN_EN | AC_PINCTL_VREF_50)

#define PIN_VREFGRD	(AC_PINCTL_IN_EN | AC_PINCTL_VREF_GRD)

#define PIN_VREF80		(AC_PINCTL_IN_EN | AC_PINCTL_VREF_80)

#define PIN_VREF100	(AC_PINCTL_IN_EN | AC_PINCTL_VREF_100)

#define PIN_OUT		(AC_PINCTL_OUT_EN)

#define PIN_HP			(AC_PINCTL_OUT_EN | AC_PINCTL_HP_EN)

#define PIN_HP_AMP		(AC_PINCTL_HP_EN)



/*

 * get widget capabilities