Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35c8ce6a authored by Damien Lespiau's avatar Damien Lespiau Committed by Daniel Vetter
Browse files

drm/i915/skl: Fix always true comparison in a revision id check 



It's always a good idea to keep static analysis happy (also because it
prompts doing the check like I proposed :), this time smatch complains:

drivers/gpu/drm/i915/intel_ringbuffer.c:891 gen9_init_workarounds() warn:
  always true condition '((->dev->pdev->revision) >= (0)) => (0-255 >= 0)'

That's because revision is a u8. Tweak a bit the condition then.

Cc: Nick Hoath <nicholas.hoath@intel.com>
Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Reviewed-by: default avatarNick Hoath <nicholas.hoath@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 77719d28

drivers/gpu/drm/i915/intel_ringbuffer.c

+2 −2
Original line number Diff line number Diff line
@@ -957,8 +957,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *ring) 
	WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,

			  GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);



	if (INTEL_REVID(dev) >= SKL_REVID_A0 &&

	    INTEL_REVID(dev) <= SKL_REVID_B0) {

	if (INTEL_REVID(dev) == SKL_REVID_A0 ||

	    INTEL_REVID(dev) == SKL_REVID_B0) {

		/*

		* WaDisableDgMirrorFixInHalfSliceChicken5:skl

		* This is a pre-production w/a.