Commit 35a8e16a authored Jun 23, 2014 by Markos Chandras Committed by Ralf Baechle Jun 26, 2014

MIPS: bpf: Use the LO register to get division's quotient

Reading from the HI register to get the division result is wrong.
The quotient is placed in the LO register.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Daniel Borkmann <dborkman@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: netdev@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/7122/

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

parent 84c68cbc

arch/mips/net/bpf_jit.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -408,7 +408,7 @@ static inline void emit_div(unsigned int dst, unsigned int src,
	u32 *p = &ctx->target[ctx->idx];		u32 *p = &ctx->target[ctx->idx];
	uasm_i_divu(&p, dst, src);		uasm_i_divu(&p, dst, src);
	p = &ctx->target[ctx->idx + 1];		p = &ctx->target[ctx->idx + 1];
	uasm_i_mfhi(&p, dst);		uasm_i_mflo(&p, dst);
	}		}
	ctx->idx += 2; /* 2 insts */		ctx->idx += 2; /* 2 insts */
	}		}