Commit 344fe786 authored Jul 30, 2006 by Josh Triplett Committed by Linus Torvalds Jul 31, 2006

[PATCH] ufs: remove incorrect unlock_kernel from failure path in ufs_symlink()



ufs_symlink, in one of its error paths, calls unlock_kernel without ever
having called lock_kernel(); fix this by creating and jumping to a new
label out_notlocked rather than the out label used after calling
lock_kernel().

Signed-off-by: Josh Triplett <josh@freedesktop.org>
Cc: Evgeniy Dushistov <dushistov@mail.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 0bee8d28

fs/ufs/namei.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -129,7 +129,7 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry,
		struct inode * inode;

		if (l > sb->s_blocksize)
		goto out;
		goto out_notlocked;

		lock_kernel();
		inode = ufs_new_inode(dir, S_IFLNK \| S_IRWXUGO);
		@@ -155,6 +155,7 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry,
		err = ufs_add_nondir(dentry, inode);
		out:
		unlock_kernel();
		out_notlocked:
		return err;

		out_fail: