Commit 33c133cc authored Dec 20, 2013 by Sergei Shtylyov Committed by David S. Miller Dec 29, 2013

phy: IRQ cannot be shared

With the way PHY IRQ handler is implemented (all real handling being pushed to
the workqueue and returning IRQ_HANDLED all the time PHY is active), we cannot
really claim that PHY IRQ can be shared when calling request_irq().

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f81152e3

drivers/net/phy/phy.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -565,9 +565,7 @@ int phy_start_interrupts(struct phy_device *phydev)
		int err = 0;

		atomic_set(&phydev->irq_disable, 0);
		if (request_irq(phydev->irq, phy_interrupt,
		IRQF_SHARED,
		"phy_interrupt",
		if (request_irq(phydev->irq, phy_interrupt, 0, "phy_interrupt",
		phydev) < 0) {
		pr_warn("%s: Can't get IRQ %d (PHY)\n",
		phydev->bus->name, phydev->irq);