Commit 33799a6d authored Jul 29, 2016 by Amitoj Kaur Chawla Committed by Ralf Baechle Aug 01, 2016

MIPS: Modify error handling



debugfs_create_file returns NULL on error so an IS_ERR test is
incorrect here and a NULL check is required.

The Coccinelle semantic patch used to make this change is as follows:
@@
expression e;
@@

  e = debugfs_create_file(...);
if(
-    IS_ERR(e)
+    !e
    )
    {
  <+...
  return
- PTR_ERR(e)
+ -ENOMEM
  ;
  ...+>
  }

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: julia.lawall@lip6.fr
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/13834/


Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

parent 11f76903

arch/mips/mm/sc-debugfs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -73,8 +73,8 @@ static int __init sc_debugfs_init(void)

		file = debugfs_create_file("prefetch", S_IRUGO \| S_IWUSR, dir,
		NULL, &sc_prefetch_fops);
		if (IS_ERR(file))
		return PTR_ERR(file);
		if (!file)
		return -ENOMEM;

		return 0;
		}