Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 332b295d authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

[media] platform: Deletion of unnecessary checks before two function calls 



The functions i2c_put_adapter() and release_firmware() test whether their
argument is NULL and then return immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 3dd94f00

drivers/media/platform/exynos4-is/fimc-is.c

+2 −4
Original line number Diff line number Diff line
@@ -428,7 +428,6 @@ static void fimc_is_load_firmware(const struct firmware *fw, void *context) 
	 * needed around for copying to the IS working memory every

	 * time before the Cortex-A5 is restarted.

	 */

	if (is->fw.f_w)

	release_firmware(is->fw.f_w);

	is->fw.f_w = fw;

done:
@@ -937,7 +936,6 @@ static int fimc_is_remove(struct platform_device *pdev) 
	vb2_dma_contig_cleanup_ctx(is->alloc_ctx);

	fimc_is_put_clocks(is);

	fimc_is_debugfs_remove(is);

	if (is->fw.f_w)

	release_firmware(is->fw.f_w);

	fimc_is_free_cpu_memory(is);

drivers/media/platform/s3c-camif/camif-core.c

+1 −2
Original line number Diff line number Diff line
@@ -256,7 +256,6 @@ static void camif_unregister_sensor(struct camif_dev *camif) 
	v4l2_device_unregister_subdev(sd);

	camif->sensor.sd = NULL;

	i2c_unregister_device(client);

	if (adapter)

	i2c_put_adapter(adapter);

}