Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3317208c authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: kirkwood: Don't set unused struct snd_pcm_hardware fields 



The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 6ce4eac1

sound/soc/kirkwood/kirkwood-dma.c

+0 −16
Original line number Diff line number Diff line
@@ -21,16 +21,6 @@ 
#include <sound/soc.h>

#include "kirkwood.h"



#define KIRKWOOD_RATES \

	(SNDRV_PCM_RATE_8000_192000 |		\

	 SNDRV_PCM_RATE_CONTINUOUS |		\

	 SNDRV_PCM_RATE_KNOT)



#define KIRKWOOD_FORMATS \

	(SNDRV_PCM_FMTBIT_S16_LE | \

	 SNDRV_PCM_FMTBIT_S24_LE | \

	 SNDRV_PCM_FMTBIT_S32_LE)



static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs)

{

	struct snd_soc_pcm_runtime *soc_runtime = subs->private_data;
@@ -43,12 +33,6 @@ static struct snd_pcm_hardware kirkwood_dma_snd_hw = { 
		 SNDRV_PCM_INFO_MMAP_VALID |

		 SNDRV_PCM_INFO_BLOCK_TRANSFER |

		 SNDRV_PCM_INFO_PAUSE),

	.formats		= KIRKWOOD_FORMATS,

	.rates			= KIRKWOOD_RATES,

	.rate_min		= 8000,

	.rate_max		= 384000,

	.channels_min		= 1,

	.channels_max		= 8,

	.buffer_bytes_max	= KIRKWOOD_SND_MAX_BUFFER_BYTES,

	.period_bytes_min	= KIRKWOOD_SND_MIN_PERIOD_BYTES,

	.period_bytes_max	= KIRKWOOD_SND_MAX_PERIOD_BYTES,