Commit 32582ffb authored Dec 24, 2013 by Chih-Wei Huang Committed by Amit Pundir Oct 24, 2016

cpufreq: interactive: fix compiling warnings

The gcc warns like:

cpufreq_interactive.c:745:6: warning: operation on 'ret' may be undefined [-Wsequence-point]

It was introduced by commit cf0fad49d17cb8273ce555dd5b7afab67d7923bf.

Since sprintf(...) just return 1 (one character) in this case, ret should not changed.
Just discarding the result of sprintf(...) leads to the result that
the committer of cf0fad49d17cb8273ce555dd5b7afab67d7923bf wants.

Change-Id: Ifed1cef6d6a31c3ed23dad03a567b3b9eddf3a57
Signed-off-by: Chih-Wei Huang <cwhuang@android-x86.org>

parent acebb7ae

drivers/cpufreq/cpufreq_interactive.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -752,7 +752,7 @@ static ssize_t show_target_loads(
		ret += sprintf(buf + ret, "%u%s", tunables->target_loads[i],
		i & 0x1 ? ":" : " ");

		ret += sprintf(buf + --ret, "\n");
		sprintf(buf + ret - 1, "\n");
		spin_unlock_irqrestore(&tunables->target_loads_lock, flags);
		return ret;
		}
		@@ -792,7 +792,7 @@ static ssize_t show_above_hispeed_delay(
		tunables->above_hispeed_delay[i],
		i & 0x1 ? ":" : " ");

		ret += sprintf(buf + --ret, "\n");
		sprintf(buf + ret - 1, "\n");
		spin_unlock_irqrestore(&tunables->above_hispeed_delay_lock, flags);
		return ret;
		}