Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3213afb8 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Revert "Input: zforce - don't overwrite the stack"

This reverts commit 7d01cd26 because
with given FRAME_MAXSIZE of 257 the check will never trigger and it
causes warnings from GCC (with -Wtype-limits). Also the check was
incorrect as it was not accounting for the already read 2 bytes of data
stored in the buffer.
parent d5806926
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -429,7 +429,7 @@ static int zforce_read_packet(struct zforce_ts *ts, u8 *buf)
		goto unlock;
	}

	if (buf[PAYLOAD_LENGTH] == 0 || buf[PAYLOAD_LENGTH] > FRAME_MAXSIZE) {
	if (buf[PAYLOAD_LENGTH] == 0) {
		dev_err(&client->dev, "invalid payload length: %d\n",
			buf[PAYLOAD_LENGTH]);
		ret = -EIO;