Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31e32227 authored by Neil Zhang's avatar Neil Zhang Committed by Felipe Balbi
Browse files

usb: phy: initialize the notifier when add a new phy 



We need to initialize the notifer before use it.

So lets initialize it when add a new phy device to
reduce the code redundancy.

Signed-off-by: default avatarNeil Zhang <zhangwm@marvell.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 1b2e21b0

drivers/usb/phy/phy-ab8500-usb.c

+0 −2
Original line number Diff line number Diff line
@@ -1415,8 +1415,6 @@ static int ab8500_usb_probe(struct platform_device *pdev) 


	platform_set_drvdata(pdev, ab);



	ATOMIC_INIT_NOTIFIER_HEAD(&ab->phy.notifier);



	/* all: Disable phy when called from set_host and set_peripheral */

	INIT_WORK(&ab->phy_dis_work, ab8500_usb_phy_disable_work);

drivers/usb/phy/phy-generic.c

+0 −1
Original line number Diff line number Diff line
@@ -210,7 +210,6 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_gen_xceiv *nop, 
	nop->phy.otg->set_host		= nop_set_host;

	nop->phy.otg->set_peripheral	= nop_set_peripheral;



	ATOMIC_INIT_NOTIFIER_HEAD(&nop->phy.notifier);

	return 0;

}

EXPORT_SYMBOL_GPL(usb_phy_gen_create_phy);

drivers/usb/phy/phy-gpio-vbus-usb.c

+0 −2
Original line number Diff line number Diff line
@@ -314,8 +314,6 @@ static int gpio_vbus_probe(struct platform_device *pdev) 
		goto err_irq;

	}



	ATOMIC_INIT_NOTIFIER_HEAD(&gpio_vbus->phy.notifier);



	INIT_DELAYED_WORK(&gpio_vbus->work, gpio_vbus_work);



	gpio_vbus->vbus_draw = regulator_get(&pdev->dev, "vbus_draw");

drivers/usb/phy/phy-mxs-usb.c

+0 −2
Original line number Diff line number Diff line
@@ -167,8 +167,6 @@ static int mxs_phy_probe(struct platform_device *pdev) 
	mxs_phy->phy.notify_disconnect	= mxs_phy_on_disconnect;

	mxs_phy->phy.type		= USB_PHY_TYPE_USB2;



	ATOMIC_INIT_NOTIFIER_HEAD(&mxs_phy->phy.notifier);



	mxs_phy->clk = clk;



	platform_set_drvdata(pdev, &mxs_phy->phy);

drivers/usb/phy/phy.c

+4 −0
Original line number Diff line number Diff line
@@ -329,6 +329,8 @@ int usb_add_phy(struct usb_phy *x, enum usb_phy_type type) 
		return -EINVAL;

	}



	ATOMIC_INIT_NOTIFIER_HEAD(&x->notifier);



	spin_lock_irqsave(&phy_lock, flags);



	list_for_each_entry(phy, &phy_list, head) {
@@ -367,6 +369,8 @@ int usb_add_phy_dev(struct usb_phy *x) 
		return -EINVAL;

	}



	ATOMIC_INIT_NOTIFIER_HEAD(&x->notifier);



	spin_lock_irqsave(&phy_lock, flags);

	list_for_each_entry(phy_bind, &phy_bind_list, list)

		if (!(strcmp(phy_bind->phy_dev_name, dev_name(x->dev))))